TODO messages in aiscripts
Moderators: Moderators for English X Forum, Scripting / Modding Moderators
-
- Posts: 4
- Joined: Sun, 17. Nov 13, 14:02
TODO messages in aiscripts
So with all the issues with the storyline missions (freighter failing to move/dock/trade etc) I figured I'd have a poke around and see if these were things that could be modified.
I noticed a few TODO messages. A few, actually. The aiscripts folder has 91 TODO lines over 38 files.
(in trade.ship)
<!-- TODO: we should check for things like broken jump drive, so we can go in for repairs instead of endlessly trying to jump to a trade -->
(in mining.ship.station)
<!-- TODO: don't just go to the zone center, find an asteroid/gas cloud... and go there -->
And so on: http://pastie.org/8486943
I'm still wrapping my head around how all the scripts interact, but it looks to me that there's some bugfixing that we could be doing in these scripts to try and sort out trading etc, given Egosoft don't appear to view anything as broken.
Anyone else feel like taking a gander at this lot? I'm at least trying to figure out why trading appears to be utterly broken!
I noticed a few TODO messages. A few, actually. The aiscripts folder has 91 TODO lines over 38 files.
(in trade.ship)
<!-- TODO: we should check for things like broken jump drive, so we can go in for repairs instead of endlessly trying to jump to a trade -->
(in mining.ship.station)
<!-- TODO: don't just go to the zone center, find an asteroid/gas cloud... and go there -->
And so on: http://pastie.org/8486943
I'm still wrapping my head around how all the scripts interact, but it looks to me that there's some bugfixing that we could be doing in these scripts to try and sort out trading etc, given Egosoft don't appear to view anything as broken.
Anyone else feel like taking a gander at this lot? I'm at least trying to figure out why trading appears to be utterly broken!
-
- Posts: 3
- Joined: Sun, 17. Nov 13, 12:59
-
- Posts: 172
- Joined: Wed, 6. Nov 02, 20:31
-
- Posts: 210
- Joined: Sun, 4. Feb 07, 00:22
-
- Posts: 718
- Joined: Wed, 3. Jul 13, 03:21
-
- Posts: 7150
- Joined: Fri, 8. Apr 05, 19:09
-
- Posts: 4
- Joined: Sun, 17. Nov 13, 14:02
Couldn't agree more - comments in any big software project tend towards being utterly out of date or incorrect over time. But there are a lot of them, and a glance at each tends to suggest that actually, most of them are still relevant, since they're next to conditionals that they need to improve (and haven't) and so on.enenra wrote:Dev comments are not necessarily representative of actual workings. There were tons of them in the previous games as well. Not all of them get removed, not all of them are actually still relevant.
I also looked in the libraries and md folders and found almost 500 TODO messages. Many of them do appear to relate (in the bits I've looked at) to currently bugged stuff. Hence my worry.[/i]
-
- Posts: 21
- Joined: Wed, 16. Nov 05, 08:20