[Official Mod Development Bug Reports] A Thread for Mod Creators

[Marvin Martian]

"on a per funtion basis"
but THAT is exactly what i try to say! this not a practical way to add a single link, it will be already a problem if two mods try to add a link, thats designed to fail!

instead of "patch" the XML you could add a link by some conditons in your own CUE, so why is there not a simple "extends function" possible in this special case?

come on, that can't be serious!

why not a "hook" function on some good positions to grab requests in case no vanilla conditions had catched up that point and ... don't know any callback-magic-stuff

OR like i suggested the post before, use an array to build the menu

really, i like to see a try to go far away from that 6(5)-PointPainMenu, but this thing will be much more worse

[Phipsz]

I didn't look at the new menu_neworder, but what I think you want to do is possible. if there is a list you and other modders
want to add an entry to, then that is possble, look at the sidebar. we have multiple mods that are adding entries to the sidebar
menu and everyones shows up, not only the last one. the replacement on a per function basis that Yorrick mentioned is not
really a replacement but, if done correctly, an extension on a per function basis. if it were a replacement, everyone adding
menu entries would have to use my sidebar extender, but, seeing that is not the case, the extension obviously works for adding
entries. if you would want to completely rework the menu, well, that would be something else

[Sparky Sparkycorp]

really, i like to see a try to go far away from that 6(5)-PointPainMenu, but this thing will be much more worse

Just an aside in case any use outside this discusson: The Drone Ability Menu has 10 buttons and if any object is selected, the name of the object (or a similar shortened version) is written in the centre of the menu. So I guess in some way, commands could be transmitted out to objects via mods.

Since the vanilla options are not context-depend, I'd personally be happy if the menu was hijacked by mods if something is selected. Well, perhaps Smart Defense could be considered context dependent since we my have less time and interest in deselecting targets, but that still leaves 9.

[jth]

When menu-production.lua initially displays there are a number of Stock/limits fields that show up as xxx / yyyy

When the values are updated they only shows Stock xxxx

The gMain_object_closeup is getting it right but the gMain_objectProduction is not on update. I think that the Stock/Limit thing has only just been added to the gui

Also it would be nice if the production\hour field in menu-production.lua could be updated regularly as this can change due to hull damage etc etc

If you change menu_production.lua, function menu.updateWares, the Helper.updateCellText line

from

Code: Select all

Helper.updateCellText(menu.selecttable, headerrow + i, 3, ConvertIntegerString(ware.amount, true, 4, false))

to

Code: Select all

Helper.updateCellText(menu.selecttable, headerrow + i, 3, ConvertIntegerString(ware.amount, true, 4, true) .. " / " .. ConvertIntegerString(GetWareProductionLimit(menu.container or menu.object, ware.ware), true, 4, true))

that borrows the line from menu.addWares and should fix the stock/limit issue

Thats the easy bit

EDIT 17/01/2016
To update the production\hour the fourth field needs updating too

Code: Select all

function menu.updateWares(waretable, oldwaretable, headerrow)
	local usage = -1
	if headerrow == 4 then 
		usage = 1
	end
	if #waretable ~= 0 then
		for i, ware in ipairs(waretable) do
			if oldwaretable[i].amount ~= ware.amount then
				oldwaretable[i].amount = ware.amount
				Helper.updateCellText(menu.selecttable, headerrow + i, 3, ConvertIntegerString(ware.amount, true, 4, true) .. " / " .. ConvertIntegerString(GetWareProductionLimit(menu.container or menu.object, ware.ware), true, 4, true))
				Helper.updateCellText(menu.selecttable, headerrow + i, 4, ConvertIntegerString(usage * ware.cycle * 3600 / menu.proddata.cycletime, true, 4, true))
			end
		end
	end
end

Regards

jth

[florianlt]

thanks for catching that. Fixed in an upcoming build.

Code: Select all

	local usage = -1
	if headerrow == 4 then 
		usage = 1
	end

That is an evil hack.

[j.harshaw]

And OP updated.

13) Vile lua stuff - jth

- FIXED

I think that covers everything up to this point. If we missed something, please poke me with a PM.

=== NOTED UP TO THIS POINT ===

[jth]

more lua stuff

version 3.61. I expect 4.00 to do this too

Found this one yesterday while looking at a Missile Forge as it flipped to the next type of missile and continued to show the missile type that was building when I opened menu-production.lua a few minutes before

At that point all the primary ware fields need updating plus all the Consumption fields (did update but got the answer wrong may be pointing to the wrong missile type).

Not sure if it would be easier\safer to just reload the whole page.

I expect the Turret Forge to have the same problems

jth

[Marvin Martian]

i'm working on a replacer mod for the pirate outposts from good for nothing into tradestations and pirate-smallship-shipyards
but i need to patch the production what is not possible as far i know, so i decided to destroy the station, because of they will spawn again anyway - but that doesnt' work well, for the reason of missing Managers and other control entities

so i need to patch the new stations with clean up all and do a 'init station' for myself again

so my bugreport:
in case you destroy a station by scripting, next game loaded the station get created again, but the manager, defence, engineer are missing!
i read something similar about the 4.0.0 new tradestations, and this should been fixed, but it seems at 400b6hf1 to me not!

[UniTrader]

@Marvin

what about removing the Production Modules and then patching the Station to re-add them? this should only remove non-essential actors, if at all

[Marvin Martian]

could be a solution, but because of the player should not have "friends" at pirate Outposts this shouldn't be a problem

if the station get new and nicely build this should be working better in that case

sideeffect is here that reivers start there daily work now at the new shipyard and the first habitat on there way is like a honypot

[Marvin Martian]

I have this at my debuglog multiple times

Code: Select all

[General] ======================================
[=ERROR=] AIDirector::Move(): Possibly infinite wake request loop: lib.ammo.drones on entity 0x3002, wake reason mask=0001
[General] ======================================
[General] ======================================
[=ERROR=] AIDirector::Move(): Possibly infinite wake request loop: trade.station on entity 0x3002, wake reason mask=0040
[General] ======================================
[General] ======================================
[=ERROR=] AIDirector::Move(): Possibly infinite wake request loop: move.park on entity 0x193e6, wake reason mask=0001
[General] ======================================
[General] ======================================
[=ERROR=] AIDirector::Move(): Possibly infinite wake request loop: lib.ammo.drones on entity 0x3002, wake reason mask=0001
[General] ======================================
[General] ======================================
[=ERROR=] AIDirector::Move(): Possibly infinite wake request loop: trade.station on entity 0x3002, wake reason mask=0040
[General] ======================================
[General] ======================================
[=ERROR=] AIDirector::Move(): Possibly infinite wake request loop: move.park on entity 0x193e6, wake reason mask=0001
[General] ======================================
[General] ======================================
[=ERROR=] AIDirector::Move(): Possibly infinite wake request loop: lib.ammo.drones on entity 0x3002, wake reason mask=0001
[General] ======================================
[General] ======================================
[=ERROR=] AIDirector::Move(): Possibly infinite wake request loop: trade.station on entity 0x3002, wake reason mask=0040
[General] ======================================
[General] ======================================
[=ERROR=] AIDirector::Move(): Possibly infinite wake request loop: move.park on entity 0x193e6, wake reason mask=0001
[General] ======================================

normaly i would post it at the beta-bug forum but in case i will only hear that this is the bugthread for modified so i post it here

the point is, i have not modified any of these files as far i know, so in my opinion, it seems to be a vanilla bug

maybe someone will take a look into, or not

[Sparky Sparkycorp]

In case it helps, that error was also reported in the following old mod threads:

23.11.2013: Functional Trader + stable supply/demand (0.22 final WIP)

14.07.2014: Manual Command Extension v0.20

I doubt you're using those mods but perhaps listing yours could help Devs gain a clue about where any interactions are occurring. Would you be able to narrow it down to a particular mod(s) that causes it?

[j.harshaw]

Hey Marvin, thanks for the report. Would you happen to have a save where the debuglog spam spews reliably?

[Marvin Martian]

Code: Select all

[=ERROR=] Widget system error. Vertical space left (790) doesn't suffice to display the requested table (calculated required min height: 928). Table will not be displayed.

my it not possible to make a scrollbox inside the avalible space?
with longer Lists at show_help will not displayed, but in case you write it in the log, you screw it up too

to reproduce:
create a long logentry with a lot of new lines

[Clownmug]

I'm having an odd problem with one of my mods at the moment. It seems that if I use <destroy_object/> or <destroy_group/> to destroy region objects, then the game will crash if the player is within the same cluster. If I try destroying regions immediately after <event_game_loaded/>, then the game freezes indefinitely.

[DocAce]

What is the object you're destroying? An asteroid (or something similar) from a region, or the region itself? The latter isn't really supported, and I would not be surprised if it crashed.

[Clownmug]

The object is the whole region. I had never had problems with destroying regions until around Beta 6 or 7, then it would start freezing the game if I didn't add delays to the code. After RC2 the only way I can do it now without crashing or freezing is by warping the player to another system, destroying the region(s), then warp the player back after waiting 1-2 seconds.

[CBJ]

As DocAce said, removing regions is not supported, and crashes are not at all unexpected. Indeed I wouldn't be surprised if it crashed occasionally even when you move the player out of the system.

[Clownmug]

Ok, I understand why it wouldn't need to be supported officially, but it did work flawlessly before 4.0, even if it wasn't by design.

[Sparky Sparkycorp]

Hi Clownmug,

It doesn't sound like you've unearthed a bug at the moment so you're thread's now in this one in case support is possible later on. Please see the OP in case there's any info requests that could be useful.